Merge pull request #162 from gcmurphy/bugfix

Cleanup vet failures and unused files
This commit is contained in:
Grant Murphy 2018-01-30 09:42:24 +10:00 committed by GitHub
commit 8125622cde
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 32 deletions

View file

@ -1,7 +1,6 @@
package gas_test
import (
"bytes"
"io/ioutil"
"log"
"os"
@ -20,10 +19,9 @@ var _ = Describe("Analyzer", func() {
var (
analyzer *gas.Analyzer
logger *log.Logger
output *bytes.Buffer
)
BeforeEach(func() {
logger, output = testutils.NewLogger()
logger, _ = testutils.NewLogger()
analyzer = gas.NewAnalyzer(nil, logger)
})

25
glide.lock generated
View file

@ -1,25 +0,0 @@
hash: fb4cbcb4f806804f30683cd298d9316522f1d7678498039eccdb29f020de1c7f
updated: 2017-05-09T21:54:08.9517391-07:00
imports:
- name: github.com/kisielk/gotool
version: 0de1eaf82fa3f583ce21fde859f1e7e0c5e9b220
- name: github.com/nbutton23/zxcvbn-go
version: a22cb81b2ecdde8b68e9ffb8824731cbf88e1de4
subpackages:
- adjacency
- data
- entropy
- frequency
- match
- matching
- scoring
- utils/math
- name: github.com/ryanuber/go-glob
version: 572520ed46dbddaed19ea3d9541bdd0494163693
- name: golang.org/x/tools
version: 1dbffd0798679c0c6b466e620725135944cfddea
subpackages:
- go/ast/astutil
- go/buildutil
- go/loader
testImports: []

View file

@ -2,7 +2,7 @@ package gas_test
import (
. "github.com/onsi/ginkgo"
//. "github.com/onsi/gomega"
. "github.com/onsi/gomega"
)
var _ = Describe("ImportTracker", func() {
@ -15,6 +15,7 @@ var _ = Describe("ImportTracker", func() {
})
Context("when I have a valid go package", func() {
It("should record all import specs", func() {
Expect(source).To(Equal(source))
Skip("Not implemented")
})

View file

@ -1,7 +1,6 @@
package rules_test
import (
"bytes"
"fmt"
"log"
@ -17,14 +16,13 @@ var _ = Describe("gas rules", func() {
var (
logger *log.Logger
output *bytes.Buffer
config gas.Config
analyzer *gas.Analyzer
runner func(string, []testutils.CodeSample)
)
BeforeEach(func() {
logger, output = testutils.NewLogger()
logger, _ = testutils.NewLogger()
config = gas.NewConfig()
analyzer = gas.NewAnalyzer(config, logger)
runner = func(rule string, samples []testutils.CodeSample) {