From b49fef79a510c51f759b5bdb595986a782887058 Mon Sep 17 00:00:00 2001 From: Grant Murphy Date: Tue, 30 Jan 2018 09:27:55 +1000 Subject: [PATCH 1/3] Using godep not glide for dependency management --- glide.lock | 25 ------------------------- 1 file changed, 25 deletions(-) delete mode 100644 glide.lock diff --git a/glide.lock b/glide.lock deleted file mode 100644 index d76519f..0000000 --- a/glide.lock +++ /dev/null @@ -1,25 +0,0 @@ -hash: fb4cbcb4f806804f30683cd298d9316522f1d7678498039eccdb29f020de1c7f -updated: 2017-05-09T21:54:08.9517391-07:00 -imports: -- name: github.com/kisielk/gotool - version: 0de1eaf82fa3f583ce21fde859f1e7e0c5e9b220 -- name: github.com/nbutton23/zxcvbn-go - version: a22cb81b2ecdde8b68e9ffb8824731cbf88e1de4 - subpackages: - - adjacency - - data - - entropy - - frequency - - match - - matching - - scoring - - utils/math -- name: github.com/ryanuber/go-glob - version: 572520ed46dbddaed19ea3d9541bdd0494163693 -- name: golang.org/x/tools - version: 1dbffd0798679c0c6b466e620725135944cfddea - subpackages: - - go/ast/astutil - - go/buildutil - - go/loader -testImports: [] From 7c7fe752b6c35ba97859bb8d586795c8f9f19353 Mon Sep 17 00:00:00 2001 From: Grant Murphy Date: Tue, 30 Jan 2018 09:32:04 +1000 Subject: [PATCH 2/3] Fix go vet errors in tests --- analyzer_test.go | 4 +--- import_tracker_test.go | 3 ++- rules/rules_test.go | 3 +-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/analyzer_test.go b/analyzer_test.go index cff3415..3422b5c 100644 --- a/analyzer_test.go +++ b/analyzer_test.go @@ -1,7 +1,6 @@ package gas_test import ( - "bytes" "io/ioutil" "log" "os" @@ -20,10 +19,9 @@ var _ = Describe("Analyzer", func() { var ( analyzer *gas.Analyzer logger *log.Logger - output *bytes.Buffer ) BeforeEach(func() { - logger, output = testutils.NewLogger() + logger, _ = testutils.NewLogger() analyzer = gas.NewAnalyzer(nil, logger) }) diff --git a/import_tracker_test.go b/import_tracker_test.go index abde8b7..492933c 100644 --- a/import_tracker_test.go +++ b/import_tracker_test.go @@ -2,7 +2,7 @@ package gas_test import ( . "github.com/onsi/ginkgo" - //. "github.com/onsi/gomega" + . "github.com/onsi/gomega" ) var _ = Describe("ImportTracker", func() { @@ -15,6 +15,7 @@ var _ = Describe("ImportTracker", func() { }) Context("when I have a valid go package", func() { It("should record all import specs", func() { + Expect(source).To(Equal(source)) Skip("Not implemented") }) diff --git a/rules/rules_test.go b/rules/rules_test.go index 6bc0d7d..6b0f884 100644 --- a/rules/rules_test.go +++ b/rules/rules_test.go @@ -17,14 +17,13 @@ var _ = Describe("gas rules", func() { var ( logger *log.Logger - output *bytes.Buffer config gas.Config analyzer *gas.Analyzer runner func(string, []testutils.CodeSample) ) BeforeEach(func() { - logger, output = testutils.NewLogger() + logger, _ = testutils.NewLogger() config = gas.NewConfig() analyzer = gas.NewAnalyzer(config, logger) runner = func(rule string, samples []testutils.CodeSample) { From a97a196160e6d081dc87900f9d3ab7f0f93da5bb Mon Sep 17 00:00:00 2001 From: Grant Murphy Date: Tue, 30 Jan 2018 09:35:35 +1000 Subject: [PATCH 3/3] Unused import --- rules/rules_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/rules/rules_test.go b/rules/rules_test.go index 6b0f884..c42902f 100644 --- a/rules/rules_test.go +++ b/rules/rules_test.go @@ -1,7 +1,6 @@ package rules_test import ( - "bytes" "fmt" "log"