shanec/forgejo-sdk
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Split Client.getResponse to Client.doRequest & Client.getResponse. (#44)

Browse source 
There is some API that give empty response and we only need
to check HTTP status code.
example :
https://developer.github.com/v3/issues/assignees/#check-assignee

But there is no way to do this in current code because
getResponse will parse the response body and not returning
HTTP status code.

Client.doRequest makes it possible to do this.
This commit is contained in:
Iwan Budi Kusnanto 2016-08-27 00:52:08 +07:00 committed by 无闻
parent c52f7ee0cc
commit c317bcf8d1
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gogs.go
View file

@ -38,7 +38,7 @@ func (c *Client) SetHTTPClient(client *http.Client) {
c.client = client c.client = client
} }
func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, error) { func (c *Client) doRequest(method, path string, header http.Header, body io.Reader) (*http.Response, error) {
req, err := http.NewRequest(method, c.url+"/api/v1"+path, body) req, err := http.NewRequest(method, c.url+"/api/v1"+path, body)
if err != nil { if err != nil {
return nil, err return nil, err
@ -48,7 +48,11 @@ func (c *Client) getResponse(method, path string, header http.Header, body io.Re
req.Header[k] = v req.Header[k] = v
} }
resp, err := c.client.Do(req) return c.client.Do(req)
}
func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, error) {
resp, err := c.doRequest(method, path, header, body)
if err != nil { if err != nil {
return nil, err return nil, err
} }