shanec/forgejo-sdk
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

More descriptive errors when validating repo metadata (#567)

Browse source 
When creating a repository using gitea client, it performs some validation on client options and the errors returned are not descriptive enough. This PR makes the errors more precise so that the user can fix the errors easily.

Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/567
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-by: Norwin <noerw@noreply.gitea.io>
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: takirala <takirala@noreply.gitea.io>
Co-committed-by: takirala <takirala@noreply.gitea.io>
This commit is contained in:
takirala 2022-02-01 07:14:45 +08:00 committed by 6543
parent 3ff2c60a86
commit 73182f46eb
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gitea/repo.go
View file

@ -329,10 +329,10 @@ func (opt CreateRepoOption) Validate(c *Client) error {
return fmt.Errorf("name has more than 100 chars") return fmt.Errorf("name has more than 100 chars")
} }
if len(opt.Description) > 255 { if len(opt.Description) > 255 {
return fmt.Errorf("name has more than 255 chars") return fmt.Errorf("description has more than 255 chars")
} }
if len(opt.DefaultBranch) > 100 { if len(opt.DefaultBranch) > 100 {
return fmt.Errorf("name has more than 100 chars") return fmt.Errorf("default branch name has more than 100 chars")
} }
if len(opt.TrustModel) != 0 { if len(opt.TrustModel) != 0 {
if err := c.checkServerVersionGreaterThanOrEqual(version1_13_0); err != nil { if err := c.checkServerVersionGreaterThanOrEqual(version1_13_0); err != nil {