mirror of
https://github.com/securego/gosec.git
synced 2024-12-25 03:55:54 +00:00
53be8dd864
* added mappings * added cwe to template * link in function to template * moved mappings and added test cases * wording * cleanup
99 lines
2.5 KiB
Go
99 lines
2.5 KiB
Go
package gosec_test
|
|
|
|
import (
|
|
"go/ast"
|
|
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
"github.com/securego/gosec"
|
|
"github.com/securego/gosec/rules"
|
|
"github.com/securego/gosec/testutils"
|
|
)
|
|
|
|
var _ = Describe("Issue", func() {
|
|
|
|
Context("when creating a new issue", func() {
|
|
It("should create a code snippet from the specified ast.Node", func() {
|
|
var target *ast.BasicLit
|
|
source := `package main
|
|
const foo = "bar"
|
|
func main(){
|
|
println(foo)
|
|
}
|
|
`
|
|
pkg := testutils.NewTestPackage()
|
|
defer pkg.Close()
|
|
pkg.AddFile("foo.go", source)
|
|
ctx := pkg.CreateContext("foo.go")
|
|
v := testutils.NewMockVisitor()
|
|
v.Callback = func(n ast.Node, ctx *gosec.Context) bool {
|
|
if node, ok := n.(*ast.BasicLit); ok {
|
|
target = node
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
v.Context = ctx
|
|
ast.Walk(v, ctx.Root)
|
|
Expect(target).ShouldNot(BeNil())
|
|
|
|
issue := gosec.NewIssue(ctx, target, "TEST", "", gosec.High, gosec.High)
|
|
Expect(issue).ShouldNot(BeNil())
|
|
Expect(issue.Code).Should(MatchRegexp(`"bar"`))
|
|
Expect(issue.Line).Should(Equal("2"))
|
|
Expect(issue.Cwe.ID).Should(Equal(""))
|
|
})
|
|
|
|
It("should return an error if specific context is not able to be obtained", func() {
|
|
Skip("Not implemented")
|
|
})
|
|
|
|
It("should provide accurate line and file information", func() {
|
|
Skip("Not implemented")
|
|
})
|
|
|
|
It("should provide accurate line and file information for multi-line statements", func() {
|
|
var target *ast.BinaryExpr
|
|
|
|
source := `package main
|
|
import "os"
|
|
func main(){`
|
|
source += "q := `SELECT * FROM table WHERE` + \n os.Args[1] + `= ?` // nolint: gosec\n"
|
|
source += `println(q)}`
|
|
|
|
pkg := testutils.NewTestPackage()
|
|
defer pkg.Close()
|
|
pkg.AddFile("foo.go", source)
|
|
ctx := pkg.CreateContext("foo.go")
|
|
v := testutils.NewMockVisitor()
|
|
v.Callback = func(n ast.Node, ctx *gosec.Context) bool {
|
|
if node, ok := n.(*ast.BinaryExpr); ok {
|
|
target = node
|
|
}
|
|
return true
|
|
}
|
|
v.Context = ctx
|
|
ast.Walk(v, ctx.Root)
|
|
Expect(target).ShouldNot(BeNil())
|
|
|
|
// Use SQL rule to check binary expr
|
|
cfg := gosec.NewConfig()
|
|
rule, _ := rules.NewSQLStrConcat("TEST", cfg)
|
|
issue, err := rule.Match(target, ctx)
|
|
Expect(err).ShouldNot(HaveOccurred())
|
|
Expect(issue).ShouldNot(BeNil())
|
|
Expect(issue.File).Should(MatchRegexp("foo.go"))
|
|
Expect(issue.Line).Should(MatchRegexp("3-4"))
|
|
})
|
|
|
|
It("should maintain the provided severity score", func() {
|
|
Skip("Not implemented")
|
|
})
|
|
|
|
It("should maintain the provided confidence score", func() {
|
|
Skip("Not implemented")
|
|
})
|
|
|
|
})
|
|
|
|
})
|