mirror of
https://github.com/securego/gosec.git
synced 2024-11-05 19:45:51 +00:00
aecbc873ef
By allowing partial matches of selectors there are chances of collisions such as those in issue #145, this removes it to expect explicit packages for each rule. Closes #145
56 lines
1.7 KiB
Go
56 lines
1.7 KiB
Go
// (c) Copyright 2016 Hewlett Packard Enterprise Development LP
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rules
|
|
|
|
import (
|
|
"go/ast"
|
|
|
|
"github.com/GoASTScanner/gas"
|
|
)
|
|
|
|
type templateCheck struct {
|
|
gas.MetaData
|
|
calls gas.CallList
|
|
}
|
|
|
|
func (t *templateCheck) Match(n ast.Node, c *gas.Context) (*gas.Issue, error) {
|
|
if node := t.calls.ContainsCallExpr(n, c); node != nil {
|
|
for _, arg := range node.Args {
|
|
if _, ok := arg.(*ast.BasicLit); !ok { // basic lits are safe
|
|
return gas.NewIssue(c, n, t.What, t.Severity, t.Confidence), nil
|
|
}
|
|
}
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
// NewTemplateCheck constructs the template check rule. This rule is used to
|
|
// find use of tempaltes where HTML/JS escaping is not being used
|
|
func NewTemplateCheck(conf gas.Config) (gas.Rule, []ast.Node) {
|
|
|
|
calls := gas.NewCallList()
|
|
calls.Add("html/template", "HTML")
|
|
calls.Add("html/template", "HTMLAttr")
|
|
calls.Add("html/template", "JS")
|
|
calls.Add("html/template", "URL")
|
|
return &templateCheck{
|
|
calls: calls,
|
|
MetaData: gas.MetaData{
|
|
Severity: gas.Medium,
|
|
Confidence: gas.Low,
|
|
What: "this method will not auto-escape HTML. Verify data is well formed.",
|
|
},
|
|
}, []ast.Node{(*ast.CallExpr)(nil)}
|
|
}
|