mirror of
https://github.com/securego/gosec.git
synced 2024-12-27 04:55:53 +00:00
622440f167
The filelist test was non-deterministic and causing intermittent failures due to ordering. This change will ensure that the file list returns an ordered list of files in the String() method now. Additionally there were a number of test cases that the sample code was incorrect, or would not compile. These have also been corrected.
85 lines
1.9 KiB
Go
85 lines
1.9 KiB
Go
// (c) Copyright 2016 Hewlett Packard Enterprise Development LP
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rules
|
|
|
|
import (
|
|
"testing"
|
|
|
|
gas "github.com/GoASTScanner/gas/core"
|
|
)
|
|
|
|
func TestNosec(t *testing.T) {
|
|
config := map[string]interface{}{"ignoreNosec": false}
|
|
analyzer := gas.NewAnalyzer(config, nil)
|
|
analyzer.AddRule(NewSubproc(config))
|
|
|
|
issues := gasTestRunner(
|
|
`package main
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
)
|
|
|
|
func main() {
|
|
cmd := exec.Command("sh", "-c", os.Getenv("BLAH")) // #nosec
|
|
cmd.Run()
|
|
}`, analyzer)
|
|
|
|
checkTestResults(t, issues, 0, "None")
|
|
}
|
|
|
|
func TestNosecBlock(t *testing.T) {
|
|
config := map[string]interface{}{"ignoreNosec": false}
|
|
analyzer := gas.NewAnalyzer(config, nil)
|
|
analyzer.AddRule(NewSubproc(config))
|
|
|
|
issues := gasTestRunner(
|
|
`package main
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
)
|
|
|
|
func main() {
|
|
// #nosec
|
|
if true {
|
|
cmd := exec.Command("sh", "-c", os.Getenv("BLAH"))
|
|
cmd.Run()
|
|
}
|
|
}`, analyzer)
|
|
|
|
checkTestResults(t, issues, 0, "None")
|
|
}
|
|
|
|
func TestNosecIgnore(t *testing.T) {
|
|
config := map[string]interface{}{"ignoreNosec": true}
|
|
analyzer := gas.NewAnalyzer(config, nil)
|
|
analyzer.AddRule(NewSubproc(config))
|
|
|
|
issues := gasTestRunner(
|
|
`package main
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
)
|
|
|
|
func main() {
|
|
cmd := exec.Command("sh", "-c", os.Args[1]) // #nosec
|
|
cmd.Run()
|
|
}`, analyzer)
|
|
|
|
checkTestResults(t, issues, 1, "Subprocess launching with variable.")
|
|
}
|