mirror of
https://github.com/securego/gosec.git
synced 2024-11-06 03:55:50 +00:00
830cb81b29
* Support package resolution and filepaths This change introduces the logic to resolve packages using gotool and build packages from filepaths. It assumes that the packages being scanned are located within the GOPATH. If the GOPATH environment variable is not set the GOPATH is derived as $HOME/go. Relates to #184 * Fix build error * Address unhandled error * Fix formatting error * Handle multiple paths on GOPATH
340 lines
8.2 KiB
Go
340 lines
8.2 KiB
Go
// (c) Copyright 2016 Hewlett Packard Enterprise Development LP
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package main
|
|
|
|
import (
|
|
"flag"
|
|
"fmt"
|
|
"log"
|
|
"os"
|
|
"os/user"
|
|
"path/filepath"
|
|
"regexp"
|
|
"runtime"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/GoASTScanner/gas"
|
|
"github.com/GoASTScanner/gas/output"
|
|
"github.com/GoASTScanner/gas/rules"
|
|
"github.com/kisielk/gotool"
|
|
)
|
|
|
|
const (
|
|
usageText = `
|
|
GAS - Go AST Scanner
|
|
|
|
Gas analyzes Go source code to look for common programming mistakes that
|
|
can lead to security problems.
|
|
|
|
VERSION: %s
|
|
GIT TAG: %s
|
|
BUILD DATE: %s
|
|
|
|
USAGE:
|
|
|
|
# Check a single package
|
|
$ gas $GOPATH/src/github.com/example/project
|
|
|
|
# Check all packages under the current directory and save results in
|
|
# json format.
|
|
$ gas -fmt=json -out=results.json ./...
|
|
|
|
# Run a specific set of rules (by default all rules will be run):
|
|
$ gas -include=G101,G203,G401 ./...
|
|
|
|
# Run all rules except the provided
|
|
$ gas -exclude=G101 $GOPATH/src/github.com/example/project/...
|
|
|
|
`
|
|
)
|
|
|
|
var (
|
|
// #nosec flag
|
|
flagIgnoreNoSec = flag.Bool("nosec", false, "Ignores #nosec comments when set")
|
|
|
|
// format output
|
|
flagFormat = flag.String("fmt", "text", "Set output format. Valid options are: json, yaml, csv, junit-xml, html, or text")
|
|
|
|
// output file
|
|
flagOutput = flag.String("out", "", "Set output file for results")
|
|
|
|
// config file
|
|
flagConfig = flag.String("conf", "", "Path to optional config file")
|
|
|
|
// quiet
|
|
flagQuiet = flag.Bool("quiet", false, "Only show output when errors are found")
|
|
|
|
// rules to explicitly include
|
|
flagRulesInclude = flag.String("include", "", "Comma separated list of rules IDs to include. (see rule list)")
|
|
|
|
// rules to explicitly exclude
|
|
flagRulesExclude = flag.String("exclude", "", "Comma separated list of rules IDs to exclude. (see rule list)")
|
|
|
|
// log to file or stderr
|
|
flagLogfile = flag.String("log", "", "Log messages to file rather than stderr")
|
|
|
|
// sort the issues by severity
|
|
flagSortIssues = flag.Bool("sort", true, "Sort issues by severity")
|
|
|
|
logger *log.Logger
|
|
)
|
|
|
|
// #nosec
|
|
func usage() {
|
|
|
|
usageText := fmt.Sprintf(usageText, Version, GitTag, BuildDate)
|
|
fmt.Fprintln(os.Stderr, usageText)
|
|
fmt.Fprint(os.Stderr, "OPTIONS:\n\n")
|
|
flag.PrintDefaults()
|
|
fmt.Fprint(os.Stderr, "\n\nRULES:\n\n")
|
|
|
|
// sorted rule list for ease of reading
|
|
rl := rules.Generate()
|
|
keys := make([]string, 0, len(rl))
|
|
for key := range rl {
|
|
keys = append(keys, key)
|
|
}
|
|
sort.Strings(keys)
|
|
for _, k := range keys {
|
|
v := rl[k]
|
|
fmt.Fprintf(os.Stderr, "\t%s: %s\n", k, v.Description)
|
|
}
|
|
fmt.Fprint(os.Stderr, "\n")
|
|
}
|
|
|
|
func loadConfig(configFile string) (gas.Config, error) {
|
|
config := gas.NewConfig()
|
|
if configFile != "" {
|
|
// #nosec
|
|
file, err := os.Open(configFile)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer file.Close()
|
|
if _, err := config.ReadFrom(file); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
if *flagIgnoreNoSec {
|
|
config.SetGlobal("nosec", "true")
|
|
}
|
|
return config, nil
|
|
}
|
|
|
|
func loadRules(include, exclude string) rules.RuleList {
|
|
var filters []rules.RuleFilter
|
|
if include != "" {
|
|
logger.Printf("including rules: %s", include)
|
|
including := strings.Split(include, ",")
|
|
filters = append(filters, rules.NewRuleFilter(false, including...))
|
|
} else {
|
|
logger.Println("including rules: default")
|
|
}
|
|
|
|
if exclude != "" {
|
|
logger.Printf("excluding rules: %s", exclude)
|
|
excluding := strings.Split(exclude, ",")
|
|
filters = append(filters, rules.NewRuleFilter(true, excluding...))
|
|
} else {
|
|
logger.Println("excluding rules: default")
|
|
}
|
|
return rules.Generate(filters...)
|
|
}
|
|
|
|
func saveOutput(filename, format string, issues []*gas.Issue, metrics *gas.Metrics) error {
|
|
if filename != "" {
|
|
outfile, err := os.Create(filename)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer outfile.Close()
|
|
err = output.CreateReport(outfile, format, issues, metrics)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
err := output.CreateReport(os.Stdout, format, issues, metrics)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func getenv(key, userDefault string) string {
|
|
if val := os.Getenv(key); val != "" {
|
|
return val
|
|
}
|
|
return userDefault
|
|
}
|
|
|
|
func gopath() []string {
|
|
defaultGoPath := runtime.GOROOT()
|
|
if u, err := user.Current(); err == nil {
|
|
defaultGoPath = filepath.Join(u.HomeDir, "go")
|
|
}
|
|
path := getenv("GOPATH", defaultGoPath)
|
|
paths := strings.Split(path, string(os.PathListSeparator))
|
|
for idx, path := range paths {
|
|
if abs, err := filepath.Abs(path); err == nil {
|
|
paths[idx] = abs
|
|
}
|
|
}
|
|
return paths
|
|
}
|
|
|
|
func cleanPath(path string, gopaths []string) (string, error) {
|
|
|
|
cleanFailed := fmt.Errorf("%s is not within the $GOPATH and cannot be processed", path)
|
|
nonRecursivePath := strings.TrimSuffix(path, "/...")
|
|
// do not attempt to clean directs that are resolvable on gopath
|
|
if _, err := os.Stat(nonRecursivePath); err != nil && os.IsNotExist(err) {
|
|
log.Printf("directory %s doesn't exist, checking if is a package on $GOPATH", path)
|
|
for _, basedir := range gopaths {
|
|
dir := filepath.Join(basedir, "src", nonRecursivePath)
|
|
if st, err := os.Stat(dir); err == nil && st.IsDir() {
|
|
log.Printf("located %s in %s", path, dir)
|
|
return path, nil
|
|
}
|
|
}
|
|
return "", cleanFailed
|
|
}
|
|
|
|
// ensure we resolve package directory correctly based on $GOPATH
|
|
abspath, err := filepath.Abs(path)
|
|
if err != nil {
|
|
abspath = path
|
|
}
|
|
for _, base := range gopaths {
|
|
projectRoot := filepath.FromSlash(fmt.Sprintf("%s/src/", base))
|
|
if strings.HasPrefix(abspath, projectRoot) {
|
|
return strings.TrimPrefix(abspath, projectRoot), nil
|
|
}
|
|
}
|
|
return "", cleanFailed
|
|
}
|
|
|
|
func cleanPaths(paths []string) []string {
|
|
gopaths := gopath()
|
|
var clean []string
|
|
for _, path := range paths {
|
|
cleaned, err := cleanPath(path, gopaths)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
clean = append(clean, cleaned)
|
|
}
|
|
return clean
|
|
}
|
|
|
|
func resolvePackage(pkg string, searchPaths []string) string {
|
|
for _, basedir := range searchPaths {
|
|
dir := filepath.Join(basedir, "src", pkg)
|
|
if st, err := os.Stat(dir); err == nil && st.IsDir() {
|
|
return dir
|
|
}
|
|
}
|
|
return pkg
|
|
}
|
|
|
|
func main() {
|
|
|
|
// Setup usage description
|
|
flag.Usage = usage
|
|
|
|
// Parse command line arguments
|
|
flag.Parse()
|
|
|
|
// Ensure at least one file was specified
|
|
if flag.NArg() == 0 {
|
|
fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n") // #nosec
|
|
flag.Usage()
|
|
os.Exit(1)
|
|
}
|
|
|
|
// Setup logging
|
|
logWriter := os.Stderr
|
|
if *flagLogfile != "" {
|
|
var e error
|
|
logWriter, e = os.Create(*flagLogfile)
|
|
if e != nil {
|
|
flag.Usage()
|
|
log.Fatal(e)
|
|
}
|
|
}
|
|
logger = log.New(logWriter, "[gas] ", log.LstdFlags)
|
|
|
|
// Load config
|
|
config, err := loadConfig(*flagConfig)
|
|
if err != nil {
|
|
logger.Fatal(err)
|
|
}
|
|
|
|
// Load enabled rule definitions
|
|
ruleDefinitions := loadRules(*flagRulesInclude, *flagRulesExclude)
|
|
if len(ruleDefinitions) <= 0 {
|
|
logger.Fatal("cannot continue: no rules are configured.")
|
|
}
|
|
|
|
// Create the analyzer
|
|
analyzer := gas.NewAnalyzer(config, logger)
|
|
analyzer.LoadRules(ruleDefinitions.Builders())
|
|
|
|
vendor := regexp.MustCompile(`[\\/]vendor([\\/]|$)`)
|
|
|
|
var packages []string
|
|
// Iterate over packages on the import paths
|
|
gopaths := gopath()
|
|
for _, pkg := range gotool.ImportPaths(cleanPaths(flag.Args())) {
|
|
|
|
// Skip vendor directory
|
|
if vendor.MatchString(pkg) {
|
|
continue
|
|
}
|
|
packages = append(packages, resolvePackage(pkg, gopaths))
|
|
}
|
|
|
|
if err := analyzer.Process(packages...); err != nil {
|
|
logger.Fatal(err)
|
|
}
|
|
|
|
// Collect the results
|
|
issues, metrics := analyzer.Report()
|
|
|
|
issuesFound := len(issues) > 0
|
|
// Exit quietly if nothing was found
|
|
if !issuesFound && *flagQuiet {
|
|
os.Exit(0)
|
|
}
|
|
|
|
// Sort the issue by severity
|
|
if *flagSortIssues {
|
|
sortIssues(issues)
|
|
}
|
|
|
|
// Create output report
|
|
if err := saveOutput(*flagOutput, *flagFormat, issues, metrics); err != nil {
|
|
logger.Fatal(err)
|
|
}
|
|
|
|
// Finialize logging
|
|
logWriter.Close() // #nosec
|
|
|
|
// Do we have an issue? If so exit 1
|
|
if issuesFound {
|
|
os.Exit(1)
|
|
}
|
|
}
|