mirror of
https://github.com/securego/gosec.git
synced 2024-12-26 04:25:52 +00:00
cee5fad4c3
There are some cases where the '.' character would also match any character and could lead to incorrect results. For example the regular expression - `^ioutils.WriteFile$' would match ioutils.WriteFile, but also ioutils_WriteFile. Additionally made sure that all regexp were declared using raw strings to avoid any unnecesary string escaping that potentially make the regexp difficult to read.
50 lines
1.4 KiB
Go
50 lines
1.4 KiB
Go
// (c) Copyright 2016 Hewlett Packard Enterprise Development LP
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rules
|
|
|
|
import (
|
|
gas "github.com/HewlettPackard/gas/core"
|
|
"go/ast"
|
|
"regexp"
|
|
)
|
|
|
|
type TemplateCheck struct {
|
|
gas.MetaData
|
|
call *regexp.Regexp
|
|
}
|
|
|
|
func (t *TemplateCheck) Match(n ast.Node, c *gas.Context) (gi *gas.Issue, err error) {
|
|
if node := gas.MatchCall(n, t.call); node != nil {
|
|
for _, arg := range node.Args {
|
|
if _, ok := arg.(*ast.BasicLit); !ok { // basic lits are safe
|
|
return gas.NewIssue(c, n, t.What, t.Severity, t.Confidence), nil
|
|
}
|
|
}
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func NewTemplateCheck() (r gas.Rule, n ast.Node) {
|
|
r = &TemplateCheck{
|
|
call: regexp.MustCompile(`^template\.(HTML|JS|URL)$`),
|
|
MetaData: gas.MetaData{
|
|
Severity: gas.Medium,
|
|
Confidence: gas.Low,
|
|
What: "this method will not auto-escape HTML. Verify data is well formed.",
|
|
},
|
|
}
|
|
n = (*ast.CallExpr)(nil)
|
|
return
|
|
}
|