From 3c8707c6c478bbbc28f4f7b9dbfc5b6853b75a8c Mon Sep 17 00:00:00 2001 From: Iskander Sharipov Date: Sat, 28 Jul 2018 23:18:12 +0300 Subject: [PATCH] fix duplicated index issue in Less method Found using https://go-critic.github.io/overview#dupSubExpr-ref --- cmd/gosec/sort_issues.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/gosec/sort_issues.go b/cmd/gosec/sort_issues.go index 10a86eb..570f9cc 100644 --- a/cmd/gosec/sort_issues.go +++ b/cmd/gosec/sort_issues.go @@ -10,7 +10,7 @@ type sortBySeverity []*gosec.Issue func (s sortBySeverity) Len() int { return len(s) } -func (s sortBySeverity) Less(i, j int) bool { return s[i].Severity > s[i].Severity } +func (s sortBySeverity) Less(i, j int) bool { return s[i].Severity > s[j].Severity } func (s sortBySeverity) Swap(i, j int) { s[i], s[j] = s[j], s[i] }