actions/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2024-12-25 03:55:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Restrict the maximum depth when tracking the slice bounds

Browse source 
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
This commit is contained in:
Cosmin Cojocar 2023-10-13 09:55:54 +02:00 committed by Cosmin Cojocar
parent 7e2d8d35f4
commit f338a98bf3
2 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
analyzer.go
View file

@ -370,7 +370,7 @@ func (gosec *Analyzer) CheckAnalyzers(pkg *packages.Package) {
// buildSSA runs the SSA pass which builds the SSA representation of the package. It handles gracefully any panic. // buildSSA runs the SSA pass which builds the SSA representation of the package. It handles gracefully any panic.
func (gosec *Analyzer) buildSSA(pkg *packages.Package) (interface{}, error) { func (gosec *Analyzer) buildSSA(pkg *packages.Package) (interface{}, error) {
defer func() { defer func() {
if r := recover(); r = nil { if r := recover(); r != nil {
gosec.logger.Printf("Panic when running SSA analyser on package: %s", pkg.Name) gosec.logger.Printf("Panic when running SSA analyser on package: %s", pkg.Name)
} }
}() }()

28
analyzers/slice_bounds.go
View file

@ -38,6 +38,8 @@ const (
upperBounded upperBounded
) )
const maxDepth = 20
func newSliceBoundsAnalyzer(id string, description string) *analysis.Analyzer { func newSliceBoundsAnalyzer(id string, description string) *analysis.Analyzer {
return &analysis.Analyzer{ return &analysis.Analyzer{
Name: id, Name: id,
@ -75,7 +77,7 @@ func runSliceBounds(pass *analysis.Pass) (interface{}, error) {
l, h := extractSliceBounds(slice) l, h := extractSliceBounds(slice)
newCap := computeSliceNewCap(l, h, sliceCap) newCap := computeSliceNewCap(l, h, sliceCap)
violations := []ssa.Instruction{} violations := []ssa.Instruction{}
trackSliceBounds(newCap, slice, &violations, ifs) trackSliceBounds(0, newCap, slice, &violations, ifs)
for _, s := range violations { for _, s := range violations {
switch s := s.(type) { switch s := s.(type) {
case *ssa.Slice: case *ssa.Slice:
@ -155,7 +157,11 @@ func runSliceBounds(pass *analysis.Pass) (interface{}, error) {
return nil, nil return nil, nil
} }
func trackSliceBounds(sliceCap int, slice ssa.Node, violations *[]ssa.Instruction, ifs map[ssa.If]*ssa.BinOp) { func trackSliceBounds(depth int, sliceCap int, slice ssa.Node, violations *[]ssa.Instruction, ifs map[ssa.If]*ssa.BinOp) {
if depth == maxDepth {
return
}
depth++
if violations == nil { if violations == nil {
violations = &[]ssa.Instruction{} violations = &[]ssa.Instruction{}
} }
@ -164,12 +170,12 @@ func trackSliceBounds(sliceCap int, slice ssa.Node, violations *[]ssa.Instructio
for _, refinstr := range *referrers { for _, refinstr := range *referrers {
switch refinstr := refinstr.(type) { switch refinstr := refinstr.(type) {
case *ssa.Slice: case *ssa.Slice:
checkAllSlicesBounds(sliceCap, refinstr, violations, ifs) checkAllSlicesBounds(depth, sliceCap, refinstr, violations, ifs)
switch refinstr.X.(type) { switch refinstr.X.(type) {
case *ssa.Alloc, *ssa.Parameter: case *ssa.Alloc, *ssa.Parameter:
l, h := extractSliceBounds(refinstr) l, h := extractSliceBounds(refinstr)
newCap := computeSliceNewCap(l, h, sliceCap) newCap := computeSliceNewCap(l, h, sliceCap)
trackSliceBounds(newCap, refinstr, violations, ifs) trackSliceBounds(depth, newCap, refinstr, violations, ifs)
} }
case *ssa.IndexAddr: case *ssa.IndexAddr:
indexValue, err := extractIntValue(refinstr.Index.String()) indexValue, err := extractIntValue(refinstr.Index.String())
@ -189,7 +195,7 @@ func trackSliceBounds(sliceCap int, slice ssa.Node, violations *[]ssa.Instructio
if fn, ok := refinstr.Call.Value.(*ssa.Function); ok { if fn, ok := refinstr.Call.Value.(*ssa.Function); ok {
if len(fn.Params) > parPos && parPos > -1 { if len(fn.Params) > parPos && parPos > -1 {
param := fn.Params[parPos] param := fn.Params[parPos]
trackSliceBounds(sliceCap, param, violations, ifs) trackSliceBounds(depth, sliceCap, param, violations, ifs)
} }
} }
} }
@ -198,7 +204,11 @@ func trackSliceBounds(sliceCap int, slice ssa.Node, violations *[]ssa.Instructio
} }
} }
func checkAllSlicesBounds(sliceCap int, slice *ssa.Slice, violations *[]ssa.Instruction, ifs map[ssa.If]*ssa.BinOp) { func checkAllSlicesBounds(depth int, sliceCap int, slice *ssa.Slice, violations *[]ssa.Instruction, ifs map[ssa.If]*ssa.BinOp) {
if depth == maxDepth {
return
}
depth++
if violations == nil { if violations == nil {
violations = &[]ssa.Instruction{} violations = &[]ssa.Instruction{}
} }
@ -210,7 +220,7 @@ func checkAllSlicesBounds(sliceCap int, slice *ssa.Slice, violations *[]ssa.Inst
case *ssa.Alloc, *ssa.Parameter, *ssa.Slice: case *ssa.Alloc, *ssa.Parameter, *ssa.Slice:
l, h := extractSliceBounds(slice) l, h := extractSliceBounds(slice)
newCap := computeSliceNewCap(l, h, sliceCap) newCap := computeSliceNewCap(l, h, sliceCap)
trackSliceBounds(newCap, slice, violations, ifs) trackSliceBounds(depth, newCap, slice, violations, ifs)
} }
references := slice.Referrers() references := slice.Referrers()
@ -220,12 +230,12 @@ func checkAllSlicesBounds(sliceCap int, slice *ssa.Slice, violations *[]ssa.Inst
for _, ref := range *references { for _, ref := range *references {
switch s := ref.(type) { switch s := ref.(type) {
case *ssa.Slice: case *ssa.Slice:
checkAllSlicesBounds(sliceCap, s, violations, ifs) checkAllSlicesBounds(depth, sliceCap, s, violations, ifs)
switch s.X.(type) { switch s.X.(type) {
case *ssa.Alloc, *ssa.Parameter: case *ssa.Alloc, *ssa.Parameter:
l, h := extractSliceBounds(s) l, h := extractSliceBounds(s)
newCap := computeSliceNewCap(l, h, sliceCap) newCap := computeSliceNewCap(l, h, sliceCap)
trackSliceBounds(newCap, s, violations, ifs) trackSliceBounds(depth, newCap, s, violations, ifs)
} }
} }
} }