Merge pull request #24 from csstaub/cs/smarter-creds-check

Smarter hard-coded credentials check
This commit is contained in:
Tim Kelsey 2016-07-28 10:31:33 +01:00 committed by GitHub
commit c5d271566c

View file

@ -15,9 +15,10 @@
package rules package rules
import ( import (
gas "github.com/HewlettPackard/gas/core"
"go/ast" "go/ast"
"regexp" "regexp"
gas "github.com/HewlettPackard/gas/core"
) )
type CredsAssign struct { type CredsAssign struct {
@ -30,8 +31,11 @@ func (r *CredsAssign) Match(n ast.Node, c *gas.Context) (gi *gas.Issue, err erro
for _, i := range node.Lhs { for _, i := range node.Lhs {
if ident, ok := i.(*ast.Ident); ok { if ident, ok := i.(*ast.Ident); ok {
if r.pattern.MatchString(ident.Name) { if r.pattern.MatchString(ident.Name) {
gi = gas.NewIssue(c, n, r.What, r.Severity, r.Confidence) for _, e := range node.Rhs {
break if _, ok := e.(*ast.BasicLit); ok {
return gas.NewIssue(c, n, r.What, r.Severity, r.Confidence), nil
}
}
} }
} }
} }