actions/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2024-12-26 04:25:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #165 from cosmincojocar/fix_gas_warnings

Browse source 
Fix some gas warnings
This commit is contained in:
Grant Murphy 2018-02-08 11:54:16 +10:00 committed by GitHub
commit ac4622d395
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
cmd/gas/main.go
View file

@ -149,9 +149,15 @@ func saveOutput(filename, format string, issues []*gas.Issue, metrics *gas.Metri
return err return err
} }
defer outfile.Close() defer outfile.Close()
output.CreateReport(outfile, format, issues, metrics) err = output.CreateReport(outfile, format, issues, metrics)
if err != nil {
return err
}
} else { } else {
output.CreateReport(os.Stdout, format, issues, metrics) err := output.CreateReport(os.Stdout, format, issues, metrics)
if err != nil {
return err
}
} }
return nil return nil
} }
@ -166,7 +172,7 @@ func main() {
// Ensure at least one file was specified // Ensure at least one file was specified
if flag.NArg() == 0 { if flag.NArg() == 0 {
fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n") fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n") // #nosec
flag.Usage() flag.Usage()
os.Exit(1) os.Exit(1)
} }
@ -231,7 +237,7 @@ func main() {
} }
// Finialize logging // Finialize logging
logWriter.Close() logWriter.Close() // #nosec
// Do we have an issue? If so exit 1 // Do we have an issue? If so exit 1
if issuesFound { if issuesFound {

3
testutils/pkg.go
View file

@ -128,6 +128,7 @@ func (p *TestPackage) CreateContext(filename string) *gas.Context {
// Close will delete the package and all files in that directory // Close will delete the package and all files in that directory
func (p *TestPackage) Close() { func (p *TestPackage) Close() {
if p.ondisk { if p.ondisk {
os.RemoveAll(p.Path) err := os.RemoveAll(p.Path)
log.Println(err)
} }
} }