actions/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2024-12-26 12:35:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

add issue tests

Browse source
This commit is contained in:
Adrian Lanzafame 2017-10-01 12:25:16 +10:00
parent 5a1133682a
commit 849abfc86f
1 changed files with 91 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

94
issue_test.go
View file

@ -49,7 +49,37 @@ var _ = Describe("Issue", func() {
}) })
It("should provide accurate line and file information", func() { It("should provide accurate line and file information", func() {
Fail("Not implemented") var target *ast.BasicLit
source := `package main
import (
"fmt"
"os"
)
func main(){
q := fmt.Sprintf("SELECT * FROM table WHERE %s = ?", os.Args[1]) // nolint: gas
println(q)
}
`
pkg := testutils.NewTestPackage()
defer pkg.Close()
pkg.AddFile("foo.go", source)
ctx := pkg.CreateContext("foo.go")
v := testutils.NewMockVisitor()
v.Callback = func(n ast.Node, ctx *gas.Context) bool {
if node, ok := n.(*ast.BasicLit); ok {
target = node
return false
}
return true
}
v.Context = ctx
ast.Walk(v, ctx.Root)
Expect(target).ShouldNot(BeNil())
issue := gas.NewIssue(ctx, target, "", gas.High, gas.High)
Expect(issue).ShouldNot(BeNil())
Expect(issue.File).Should(MatchRegexp("foo.go"))
Expect(issue.Line).Should(Equal("7"))
}) })
It("should provide accurate line and file information for multi-line statements", func() { It("should provide accurate line and file information for multi-line statements", func() {
@ -87,11 +117,69 @@ var _ = Describe("Issue", func() {
}) })
It("should maintain the provided severity score", func() { It("should maintain the provided severity score", func() {
Fail("Not implemented") var target *ast.BasicLit
source := `package main
import (
"fmt"
"os"
)
func main(){
q := fmt.Sprintf("SELECT * FROM table WHERE %s = ?", os.Args[1]) // nolint: gas
println(q)
}
`
pkg := testutils.NewTestPackage()
defer pkg.Close()
pkg.AddFile("foo.go", source)
ctx := pkg.CreateContext("foo.go")
v := testutils.NewMockVisitor()
v.Callback = func(n ast.Node, ctx *gas.Context) bool {
if node, ok := n.(*ast.BasicLit); ok {
target = node
return false
}
return true
}
v.Context = ctx
ast.Walk(v, ctx.Root)
Expect(target).ShouldNot(BeNil())
issue := gas.NewIssue(ctx, target, "", gas.High, gas.High)
Expect(issue).ShouldNot(BeNil())
Expect(issue.Severity).Should(Equal(gas.High))
}) })
It("should maintain the provided confidence score", func() { It("should maintain the provided confidence score", func() {
Fail("Not implemented") var target *ast.BasicLit
source := `package main
import (
"fmt"
"os"
)
func main(){
q := fmt.Sprintf("SELECT * FROM table WHERE %s = ?", os.Args[1]) // nolint: gas
println(q)
}
`
pkg := testutils.NewTestPackage()
defer pkg.Close()
pkg.AddFile("foo.go", source)
ctx := pkg.CreateContext("foo.go")
v := testutils.NewMockVisitor()
v.Callback = func(n ast.Node, ctx *gas.Context) bool {
if node, ok := n.(*ast.BasicLit); ok {
target = node
return false
}
return true
}
v.Context = ctx
ast.Walk(v, ctx.Root)
Expect(target).ShouldNot(BeNil())
issue := gas.NewIssue(ctx, target, "", gas.High, gas.High)
Expect(issue).ShouldNot(BeNil())
Expect(issue.Confidence).Should(Equal(gas.High))
}) })
}) })