mirror of
https://github.com/securego/gosec.git
synced 2024-11-05 19:45:51 +00:00
feat: add os.ReadFile to G304 (#706)
In Go 1.16 or higher, the `io/ioutil` has been deprecated and the `ioutil.ReadFile` function now calls `os.ReadFile`. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
parent
991dd94f3a
commit
7fd4aef9dc
2 changed files with 17 additions and 0 deletions
|
@ -122,6 +122,7 @@ func NewReadFile(id string, conf gosec.Config) (gosec.Rule, []ast.Node) {
|
||||||
rule.clean.Add("path/filepath", "Clean")
|
rule.clean.Add("path/filepath", "Clean")
|
||||||
rule.clean.Add("path/filepath", "Rel")
|
rule.clean.Add("path/filepath", "Rel")
|
||||||
rule.Add("io/ioutil", "ReadFile")
|
rule.Add("io/ioutil", "ReadFile")
|
||||||
|
rule.Add("os", "ReadFile")
|
||||||
rule.Add("os", "Open")
|
rule.Add("os", "Open")
|
||||||
rule.Add("os", "OpenFile")
|
rule.Add("os", "OpenFile")
|
||||||
return rule, []ast.Node{(*ast.CallExpr)(nil)}
|
return rule, []ast.Node{(*ast.CallExpr)(nil)}
|
||||||
|
|
|
@ -1787,6 +1787,22 @@ func main() {
|
||||||
}`}, 1, gosec.NewConfig()}, {[]string{`
|
}`}, 1, gosec.NewConfig()}, {[]string{`
|
||||||
package main
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"log"
|
||||||
|
)
|
||||||
|
|
||||||
|
func main() {
|
||||||
|
f := os.Getenv("tainted_file")
|
||||||
|
body, err := os.ReadFile(f)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("Error: %v\n", err)
|
||||||
|
}
|
||||||
|
log.Print(body)
|
||||||
|
|
||||||
|
}`}, 1, gosec.NewConfig()}, {[]string{`
|
||||||
|
package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
"log"
|
"log"
|
||||||
|
|
Loading…
Reference in a new issue