actions/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2024-12-26 12:35:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Temporarily disable typechecker fatal error

Browse source 
It seems that the typechecker isn't considering the entire package
fileset in the current way that gas is processing projects. This leads
to cases where types that are defined in one file aren't known about
when gas is processing other files within that module.

A redesign is needed, this is a temporary fix to return to old
behaviour.

Related to #113
This commit is contained in:
Grant Murphy 2017-01-14 15:21:55 -08:00
parent f6aeaa8dec
commit 3e9b66a91a
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/analyzer.go
View file

@ -16,7 +16,6 @@
package core package core
import ( import (
"fmt"
"go/ast" "go/ast"
"go/importer" "go/importer"
"go/parser" "go/parser"
@ -126,7 +125,10 @@ func (gas *Analyzer) process(filename string, source interface{}) error {
conf := types.Config{Importer: importer.Default()} conf := types.Config{Importer: importer.Default()}
gas.context.Pkg, err = conf.Check("pkg", gas.context.FileSet, []*ast.File{root}, gas.context.Info) gas.context.Pkg, err = conf.Check("pkg", gas.context.FileSet, []*ast.File{root}, gas.context.Info)
if err != nil { if err != nil {
return fmt.Errorf(`Error during type checking: "%s"`, err) // TODO(gm) Type checker not currently considering all files within a package
// see: issue #113
gas.logger.Printf(`Error during type checking: "%s"`, err)
err = nil
} }
gas.context.Imports = NewImportInfo() gas.context.Imports = NewImportInfo()