actions/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2024-12-25 12:05:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor AppendError to check for build.NoGoError (#1273)
Some checks are pending
CI / test (map[go:1.22.10 golangci:latest]) (push) Waiting to run
Details
CI / test (map[go:1.23.4 golangci:latest]) (push) Waiting to run
Details
CI / coverage (push) Blocked by required conditions
Details
Security Scan / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Oleksandr Redko 2024-12-19 12:55:12 +02:00 committed by GitHub
parent 9a2d74ffe0
commit 36c81ed69b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
analyzer.go
View file

@ -16,6 +16,7 @@
package gosec package gosec
import ( import (
"errors"
"fmt" "fmt"
"go/ast" "go/ast"
"go/build" "go/build"
@ -543,7 +544,8 @@ func (gosec *Analyzer) ParseErrors(pkg *packages.Package) error {
// AppendError appends an error to the file errors // AppendError appends an error to the file errors
func (gosec *Analyzer) AppendError(file string, err error) { func (gosec *Analyzer) AppendError(file string, err error) {
// Do not report the error for empty packages (e.g. files excluded from build with a tag) // Do not report the error for empty packages (e.g. files excluded from build with a tag)
if strings.Contains(err.Error(), "no buildable Go source files in") { var noGoErr *build.NoGoError
if errors.As(err, &noGoErr) {
return return
} }
errors := make([]Error, 0) errors := make([]Error, 0)

6
analyzer_test.go
View file

@ -16,6 +16,7 @@ package gosec_test
import ( import (
"errors" "errors"
"go/build"
"log" "log"
"regexp" "regexp"
"strings" "strings"
@ -1311,7 +1312,10 @@ var _ = Describe("Analyzer", func() {
Context("when appending errors", func() { Context("when appending errors", func() {
It("should skip error for non-buildable packages", func() { It("should skip error for non-buildable packages", func() {
analyzer.AppendError("test", errors.New(`loading file from package "pkg/test": no buildable Go source files in pkg/test`)) err := &build.NoGoError{
Dir: "pkg/test",
}
analyzer.AppendError("test", err)
_, _, errors := analyzer.Report() _, _, errors := analyzer.Report()
Expect(errors).To(BeEmpty()) Expect(errors).To(BeEmpty())
}) })