mirror of
https://github.com/securego/gosec.git
synced 2024-12-25 12:05:52 +00:00
Ensure initialization only imports are ignored
Blacklisted imports should not report failures when a module is imported for side-effects only using the blank identifier. Closes #59
This commit is contained in:
parent
7a275fd0ad
commit
20f2a98ce8
2 changed files with 39 additions and 1 deletions
|
@ -27,7 +27,7 @@ type BlacklistImport struct {
|
||||||
|
|
||||||
func (r *BlacklistImport) Match(n ast.Node, c *gas.Context) (gi *gas.Issue, err error) {
|
func (r *BlacklistImport) Match(n ast.Node, c *gas.Context) (gi *gas.Issue, err error) {
|
||||||
if node, ok := n.(*ast.ImportSpec); ok {
|
if node, ok := n.(*ast.ImportSpec); ok {
|
||||||
if r.Path == node.Path.Value {
|
if r.Path == node.Path.Value && node.Name.String() != "_" {
|
||||||
return gas.NewIssue(c, n, r.What, r.Severity, r.Confidence), nil
|
return gas.NewIssue(c, n, r.What, r.Severity, r.Confidence), nil
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
38
rules/blacklist_test.go
Normal file
38
rules/blacklist_test.go
Normal file
|
@ -0,0 +1,38 @@
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
package rules
|
||||||
|
|
||||||
|
import (
|
||||||
|
gas "github.com/GoASTScanner/gas/core"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
const initOnlyImportSrc = `
|
||||||
|
package main
|
||||||
|
import (
|
||||||
|
_ "crypto/md5"
|
||||||
|
"fmt"
|
||||||
|
)
|
||||||
|
func main() {
|
||||||
|
for _, arg := range os.Args {
|
||||||
|
fmt.Println(arg)
|
||||||
|
}
|
||||||
|
}`
|
||||||
|
|
||||||
|
func TestInitOnlyImport(t *testing.T) {
|
||||||
|
config := map[string]interface{}{"ignoreNosec": false}
|
||||||
|
analyzer := gas.NewAnalyzer(config, nil)
|
||||||
|
analyzer.AddRule(NewBlacklist_crypto_md5(config))
|
||||||
|
issues := gasTestRunner(initOnlyImportSrc, analyzer)
|
||||||
|
checkTestResults(t, issues, 0, "")
|
||||||
|
}
|
Loading…
Reference in a new issue