2016-07-28 12:51:25 +01:00
|
|
|
// (c) Copyright 2016 Hewlett Packard Enterprise Development LP
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package rules
|
|
|
|
|
|
|
|
import (
|
|
|
|
"testing"
|
|
|
|
|
2017-04-26 16:08:46 +01:00
|
|
|
"github.com/GoASTScanner/gas"
|
2016-07-28 12:51:25 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestNosec(t *testing.T) {
|
2016-08-05 14:27:21 +01:00
|
|
|
config := map[string]interface{}{"ignoreNosec": false}
|
|
|
|
analyzer := gas.NewAnalyzer(config, nil)
|
2016-08-10 12:51:03 +01:00
|
|
|
analyzer.AddRule(NewSubproc(config))
|
2016-07-28 12:51:25 +01:00
|
|
|
|
|
|
|
issues := gasTestRunner(
|
|
|
|
`package main
|
2017-01-13 20:40:49 +00:00
|
|
|
import (
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
|
|
|
)
|
2016-07-28 12:51:25 +01:00
|
|
|
|
2017-01-13 20:40:49 +00:00
|
|
|
func main() {
|
|
|
|
cmd := exec.Command("sh", "-c", os.Getenv("BLAH")) // #nosec
|
|
|
|
cmd.Run()
|
|
|
|
}`, analyzer)
|
2016-07-28 12:51:25 +01:00
|
|
|
|
|
|
|
checkTestResults(t, issues, 0, "None")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestNosecBlock(t *testing.T) {
|
2016-08-05 14:27:21 +01:00
|
|
|
config := map[string]interface{}{"ignoreNosec": false}
|
|
|
|
analyzer := gas.NewAnalyzer(config, nil)
|
2016-08-10 12:51:03 +01:00
|
|
|
analyzer.AddRule(NewSubproc(config))
|
2016-07-28 12:51:25 +01:00
|
|
|
|
|
|
|
issues := gasTestRunner(
|
|
|
|
`package main
|
2017-01-13 20:40:49 +00:00
|
|
|
import (
|
2017-04-26 16:08:46 +01:00
|
|
|
"os"
|
2017-03-15 15:47:40 +00:00
|
|
|
"os/exec"
|
2017-01-13 20:40:49 +00:00
|
|
|
)
|
2016-07-28 12:51:25 +01:00
|
|
|
|
2017-01-13 20:40:49 +00:00
|
|
|
func main() {
|
2016-07-28 12:51:25 +01:00
|
|
|
// #nosec
|
|
|
|
if true {
|
2017-01-13 20:40:49 +00:00
|
|
|
cmd := exec.Command("sh", "-c", os.Getenv("BLAH"))
|
|
|
|
cmd.Run()
|
2016-07-28 12:51:25 +01:00
|
|
|
}
|
2017-01-13 20:40:49 +00:00
|
|
|
}`, analyzer)
|
2016-07-28 12:51:25 +01:00
|
|
|
|
|
|
|
checkTestResults(t, issues, 0, "None")
|
|
|
|
}
|
2016-08-05 14:27:21 +01:00
|
|
|
|
|
|
|
func TestNosecIgnore(t *testing.T) {
|
|
|
|
config := map[string]interface{}{"ignoreNosec": true}
|
|
|
|
analyzer := gas.NewAnalyzer(config, nil)
|
2016-08-10 12:51:03 +01:00
|
|
|
analyzer.AddRule(NewSubproc(config))
|
2016-08-05 14:27:21 +01:00
|
|
|
|
|
|
|
issues := gasTestRunner(
|
|
|
|
`package main
|
|
|
|
|
2017-01-13 20:40:49 +00:00
|
|
|
import (
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
|
|
|
)
|
2016-08-05 14:27:21 +01:00
|
|
|
|
2017-01-13 20:40:49 +00:00
|
|
|
func main() {
|
|
|
|
cmd := exec.Command("sh", "-c", os.Args[1]) // #nosec
|
|
|
|
cmd.Run()
|
|
|
|
}`, analyzer)
|
2016-08-05 14:27:21 +01:00
|
|
|
|
|
|
|
checkTestResults(t, issues, 1, "Subprocess launching with variable.")
|
|
|
|
}
|